Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions #187

Merged
merged 14 commits into from
Nov 22, 2024
Merged

Fix GitHub actions #187

merged 14 commits into from
Nov 22, 2024

Conversation

kwongtn
Copy link
Contributor

@kwongtn kwongtn commented Nov 21, 2024

Attempting to fix github actions.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@korniltsev
Copy link
Collaborator

Idk, how to grant permission to run actions automatically and if it is permitted by grafana org.
I guess I have to hit "approve" every time. Ping me if I miss something.

Another thing you can do is to create a fork and run workflows in your fork ( it probably will not help with macOS arm64 runners though)

@kwongtn
Copy link
Contributor Author

kwongtn commented Nov 21, 2024

@korniltsev can you run the actions? I think everything is done for ruby side -- for python there are some issues with the build wheels that I'm working on

@korniltsev
Copy link
Collaborator

we cannot use stable toolchain. We need a fixed version. Moreover we should use the same toolchain version everywhere i.e. dockerfiles

&& ./rustup-init -y --default-toolchain=1.76.0 --default-host=aarch64-unknown-linux-gnu

Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please fix a specific toolchain version, not stable
  • lets try using macos-14 runners? The "11.0" we used to use is now offline and unavailable.

@korniltsev
Copy link
Collaborator

Thank you a lot! 🎉

@kwongtn kwongtn marked this pull request as ready for review November 21, 2024 11:44
@kwongtn kwongtn requested review from a team as code owners November 21, 2024 11:44
@kwongtn kwongtn requested a review from korniltsev November 21, 2024 11:44
@kwongtn
Copy link
Contributor Author

kwongtn commented Nov 21, 2024

@korniltsev I think its ready 👀

Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolchain is still stable in workflows. Please Either fix it or try to remove toolchain altogether if possible

@korniltsev
Copy link
Collaborator

Also am I understanding correctly that we are switching from arm native runner to running arm on qemu? If so, we better bring back native execution for speed, we dont need slow builds.

@korniltsev
Copy link
Collaborator

Great job!

Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
@kwongtn
Copy link
Contributor Author

kwongtn commented Nov 21, 2024

Also am I understanding correctly that we are switching from arm native runner to running arm on qemu? If so, we better bring back native execution for speed, we dont need slow builds.

Got it. Reverted at a29824a
Thought the runner was not valid

Toolchain is still stable in workflows.

Fixed 😁
1f3f80b

@kwongtn kwongtn requested a review from korniltsev November 21, 2024 16:37
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets gooo!

I recokn there maybe more issues with release/publish pipelines since we did not trigger them in this PR. I will try to release python today.

@korniltsev korniltsev merged commit e218b12 into grafana:main Nov 22, 2024
26 checks passed
@kwongtn kwongtn deleted the fix-github-actions branch November 22, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants